From 0fcaf87b1afcbec16e6dcaba9f007ea63f650601 Mon Sep 17 00:00:00 2001 From: Eliot Partridge Date: Sun, 19 Dec 2021 17:57:34 -0600 Subject: [PATCH] Improve domain matching for nag warning, add more reddit domains (#420) --- static/js/hnwarn.js | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/static/js/hnwarn.js b/static/js/hnwarn.js index b2bfeae..c56bcfe 100644 --- a/static/js/hnwarn.js +++ b/static/js/hnwarn.js @@ -2,6 +2,12 @@ import { g, x, r, t } from "./xeact.min.js"; import { div, ahref, br } from "./xeact-html.min.js"; import { mkConversation } from "./conversation.js"; +// list of regexps for potentially problematic referrers to display the nag to +const FLAGGED_REFERRERS = [ + /^https?:\/\/((.+)\.)?reddit\.com/i, + /^https?:\/\/news\.ycombinator\.com/i, +]; + const addNag = () => { let root = g("refererNotice"); x(root); @@ -20,19 +26,10 @@ const addNag = () => { }; r(() => { - switch (document.referrer) { - case "https://news.ycombinator.com/": + const ref = document.referrer; + if (!ref) return; + + if (FLAGGED_REFERRERS.some(r => r.test(ref))) { addNag(); - break; - case "https://www.reddit.com/": - addNag(); - break; - case "https://old.reddit.com/": - addNag(); - break; - case "https://reddit.com/": - addNag(); - break; } }); -