cadey
/
elemental-ircd
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix buffer overflow in introduce_client and burst_TS6 

If the client being introduced has more than 10 user modes send_umode()
will overflow ubuf

tracks Adam-/charybdis@9744d53ec9
This commit is contained in:
Sam Dodrill 2014-05-17 09:29:21 -07:00
parent d726cc83a2
commit 19d656a29b
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/s_serv.c
View File

@ -532,7 +532,7 @@ burst_modes_TS6(struct Client *client_p, struct Channel *chptr,
static void static void
burst_TS6(struct Client *client_p) burst_TS6(struct Client *client_p)
{ {
static char ubuf[12]; static char ubuf[BUFSIZE];
struct Client *target_p; struct Client *target_p;
struct Channel *chptr; struct Channel *chptr;
struct membership *msptr; struct membership *msptr;

2
src/s_user.c
View File

@ -600,7 +600,7 @@ register_local_user(struct Client *client_p, struct Client *source_p, const char
int int
introduce_client(struct Client *client_p, struct Client *source_p, struct User *user, const char *nick, int use_euid) introduce_client(struct Client *client_p, struct Client *source_p, struct User *user, const char *nick, int use_euid)
{ {
static char ubuf[12]; static char ubuf[BUFSIZE];
struct Client *identifyservice_p; struct Client *identifyservice_p;
char *p; char *p;
hook_data_umode_changed hdata; hook_data_umode_changed hdata;