Calculate change percentage correctly

Measuring percent change based on the current price instead of the
original price is silly; instead use change / old price
This commit is contained in:
Jacob Stultz 2013-11-07 10:11:09 -08:00
parent e769bad2b7
commit 80ce43e0c5
1 changed files with 6 additions and 4 deletions

View File

@ -19,16 +19,18 @@ def stock(inp):
if quote['Change'] is None:
return "unknown ticker symbol %s" % inp
if quote['Change'][0] == '-':
change = float(quote['Change'])
price = float(quote['LastTradePriceOnly'])
if change < 0:
quote['color'] = "5"
else:
quote['color'] = "3"
quote['Percent_Change'] = (100 * float(quote['Change']) /
float(quote['LastTradePriceOnly']))
quote['PercentChange'] = 100 * change / (price - change)
ret = "%(Name)s - %(LastTradePriceOnly)s " \
"\x03%(color)s%(Change)s (%(Percent_Change).2f%%)\x03 " \
"\x03%(color)s%(Change)s (%(PercentChange).2f%%)\x03 " \
"Day Range: %(DaysRange)s " \
"MCAP: %(MarketCapitalization)s" % quote