Calculate change percentage correctly
Measuring percent change based on the current price instead of the original price is silly; instead use change / old price
This commit is contained in:
parent
e769bad2b7
commit
80ce43e0c5
|
@ -19,16 +19,18 @@ def stock(inp):
|
||||||
if quote['Change'] is None:
|
if quote['Change'] is None:
|
||||||
return "unknown ticker symbol %s" % inp
|
return "unknown ticker symbol %s" % inp
|
||||||
|
|
||||||
if quote['Change'][0] == '-':
|
change = float(quote['Change'])
|
||||||
|
price = float(quote['LastTradePriceOnly'])
|
||||||
|
|
||||||
|
if change < 0:
|
||||||
quote['color'] = "5"
|
quote['color'] = "5"
|
||||||
else:
|
else:
|
||||||
quote['color'] = "3"
|
quote['color'] = "3"
|
||||||
|
|
||||||
quote['Percent_Change'] = (100 * float(quote['Change']) /
|
quote['PercentChange'] = 100 * change / (price - change)
|
||||||
float(quote['LastTradePriceOnly']))
|
|
||||||
|
|
||||||
ret = "%(Name)s - %(LastTradePriceOnly)s " \
|
ret = "%(Name)s - %(LastTradePriceOnly)s " \
|
||||||
"\x03%(color)s%(Change)s (%(Percent_Change).2f%%)\x03 " \
|
"\x03%(color)s%(Change)s (%(PercentChange).2f%%)\x03 " \
|
||||||
"Day Range: %(DaysRange)s " \
|
"Day Range: %(DaysRange)s " \
|
||||||
"MCAP: %(MarketCapitalization)s" % quote
|
"MCAP: %(MarketCapitalization)s" % quote
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue