cadey
/
h
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

down.py URL bugfix and detailed error messages 

Adjusts urlparse behaviour for schemeless URLs (see python docs) to put the domain name into netloc, and makes error messages more detailed so differentiation between a HTTP error or DNS error can occur.
This commit is contained in:
KaneTW 2014-12-03 20:10:28 +01:00
parent 94343e7891
commit 885b765888
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/down.py
View File

@ -7,6 +7,10 @@ from util import hook, http
def down(inp): def down(inp):
'''.down <url> -- checks to see if the website is down''' '''.down <url> -- checks to see if the website is down'''
# urlparse follows RFC closely, so we have to check for schema existance and prepend empty schema if necessary
if not inp.startswith('//') and '://' not in inp:
inp = '//' + inp
urlp = urlparse.urlparse(inp, 'http') urlp = urlparse.urlparse(inp, 'http')
if urlp.scheme not in ('http', 'https'): if urlp.scheme not in ('http', 'https'):
@ -18,5 +22,5 @@ def down(inp):
try: try:
http.get(inp, get_method='HEAD') http.get(inp, get_method='HEAD')
return inp + ' seems to be up' return inp + ' seems to be up'
except http.URLError: except http.URLError as error:
return inp + ' seems to be down' return inp + ' seems to be down. Error: %s' % error.reason