cadey/maj
cadey
/
maj
1
0
Fork 1
Code Issues 4 Pull Requests Releases 7 Wiki Activity

Enable CI tests for pull requests #17

Merged
cadey merged 2 commits from :pr-test into main 2020-12-15 01:21:12 +00:00
Conversation 2 Commits 2 Files Changed 1 +7 -6
Ghost commented 2020-12-10 17:14:20 +00:00
First-time contributor
Copy Link

Currently, CI tests are only run for direct pushes, which means that pull requests won't be tested until merged, unless the PR author runs the tests themselves, locally.

This could result in some bugs not immediately being caught by drone, and unintentionally megred to main.

This change only enables CI tests (specifically the rust tests step of the tests/release pipeline) for pull requests.

Currently, CI tests are only run for direct pushes, which means that pull requests won't be tested until merged, unless the PR author runs the tests themselves, locally. This could result in some bugs not immediately being caught by drone, and unintentionally megred to main. This change only enables CI tests (specifically the `rust tests` step of the `tests/release` pipeline) for pull requests.
Ghost commented 2020-12-10 17:53:36 +00:00
Author
First-time contributor
Copy Link

Note: Current build error is due to #18, but is not introduced by this PR

Note: Current build error is due to https://tulpa.dev/cadey/maj/pulls/18, but is not introduced by this PR
Ghost commented 2020-12-10 18:15:58 +00:00
Author
First-time contributor
Copy Link

Also, just pushed 3b4e9c7 which switches to using triggers instead of step conditions where relevant, so that the cargo publish pipeline doesnt go through the trouble of spinning up a docker image and cloning the repo only to immediately shut down if none of the steps apply

Also, just pushed 3b4e9c7 which switches to using triggers instead of step conditions where relevant, so that the `cargo publish` pipeline doesnt go through the trouble of spinning up a docker image and cloning the repo only to immediately shut down if none of the steps apply
cadey merged commit 6524ee688a into main 2020-12-15 01:21:12 +00:00
Ghost deleted branch pr-test 2020-12-15 01:22:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
magc

an interactive curses client for gemini

  
magd

the daemon that serves static files and lua apps

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
magc
magd
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cadey/maj#17
No description provided.
Delete Branch ":pr-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?