From c62c2be196e203ddf71a167650aa302ca8e93a39 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 4 Aug 2015 10:30:58 -0400 Subject: [PATCH] review --- ..._c8240ba3abf5cf458eba8ed7e31eaccf._comment | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 doc/todo/File.containsConfPair___38___LightDM.autoLogin_properties/comment_1_c8240ba3abf5cf458eba8ed7e31eaccf._comment diff --git a/doc/todo/File.containsConfPair___38___LightDM.autoLogin_properties/comment_1_c8240ba3abf5cf458eba8ed7e31eaccf._comment b/doc/todo/File.containsConfPair___38___LightDM.autoLogin_properties/comment_1_c8240ba3abf5cf458eba8ed7e31eaccf._comment new file mode 100644 index 0000000..a5a2b80 --- /dev/null +++ b/doc/todo/File.containsConfPair___38___LightDM.autoLogin_properties/comment_1_c8240ba3abf5cf458eba8ed7e31eaccf._comment @@ -0,0 +1,25 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2015-08-04T14:23:33Z" + content=""" +Thanks for submitting these patches! + +Looking at `containsConfPair`, it assumes an ini-style file, +so is a little misplaced in Property.File. which is otherwise about generic +text files. + +So, it would probably make sense to move it to a new Property.IniFile +module. + +However, [[forum/parsing_a_config_file]] recently pointed out that +the tor config file has a similar need. It's not ini format, but +shares the same basic idea of a "section" line which is followed by +lines setting things specific to that section. + +So, it would be great if `containsConfPair` could be generalized to also +cover that tor config file use case. I think this would be pretty easy; +just make it take one string containing the whole section line (including +square brackets for ini file, or whatever for tor config file), and a +second string containing the whole setting line. +"""]]