cadey
/
propellor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Added a comment

This commit is contained in:
spwhitton 2015-08-05 21:29:04 +00:00 committed by admin
parent c62c2be196
commit ffe9d0e1d6
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
doc/todo/File.containsConfPair___38___LightDM.autoLogin_properties/comment_2_9303138a3be2fb639498737afe60b87d._comment Normal file
View File

@ -0,0 +1,11 @@
[[!comment format=mdwn
username="spwhitton"
subject="comment 2"
date="2015-08-05T21:29:04Z"
content="""
Thanks for the input!
I agree that generalising to lines under sections is a good idea, but I don't think it can be as simple as a property taking the full section header and the full settings line. That's because there is a need to update the values of keys under sections: in the example LightDM case, the line `autologin-user=someone` must *replace* any `autologin-user=someone_else`. So the function needs to know the key, not just the whole line.
So to generalise containsConfPair, it might take a section header, key, value and a specification of what kind of config file it is. That specification would be a type containing the comment character, the formatting of section headers and the use of spaces, colons or equals signs between keys and values. What do you think to this?
"""]]