package s3_test import ( "bytes" "fmt" "io/ioutil" "net/http" "strings" "testing" "github.com/aws/aws-sdk-go/aws" "github.com/aws/aws-sdk-go/aws/awserr" "github.com/aws/aws-sdk-go/aws/request" "github.com/aws/aws-sdk-go/awstesting/unit" "github.com/aws/aws-sdk-go/service/s3" ) type testErrorCase struct { RespFn func() *http.Response ReqID, HostID string Code, Msg string WithoutStatusMsg bool } var testUnmarshalCases = []testErrorCase{ { RespFn: func() *http.Response { return &http.Response{ StatusCode: 301, Header: http.Header{ "X-Amz-Request-Id": []string{"abc123"}, "X-Amz-Id-2": []string{"321cba"}, }, Body: ioutil.NopCloser(bytes.NewReader(nil)), ContentLength: -1, } }, ReqID: "abc123", HostID: "321cba", Code: "BucketRegionError", Msg: "incorrect region, the bucket is not in 'mock-region' region", }, { RespFn: func() *http.Response { return &http.Response{ StatusCode: 403, Header: http.Header{ "X-Amz-Request-Id": []string{"abc123"}, "X-Amz-Id-2": []string{"321cba"}, }, Body: ioutil.NopCloser(bytes.NewReader(nil)), ContentLength: 0, } }, ReqID: "abc123", HostID: "321cba", Code: "Forbidden", Msg: "Forbidden", }, { RespFn: func() *http.Response { return &http.Response{ StatusCode: 400, Header: http.Header{ "X-Amz-Request-Id": []string{"abc123"}, "X-Amz-Id-2": []string{"321cba"}, }, Body: ioutil.NopCloser(bytes.NewReader(nil)), ContentLength: 0, } }, ReqID: "abc123", HostID: "321cba", Code: "BadRequest", Msg: "Bad Request", }, { RespFn: func() *http.Response { return &http.Response{ StatusCode: 404, Header: http.Header{ "X-Amz-Request-Id": []string{"abc123"}, "X-Amz-Id-2": []string{"321cba"}, }, Body: ioutil.NopCloser(bytes.NewReader(nil)), ContentLength: 0, } }, ReqID: "abc123", HostID: "321cba", Code: "NotFound", Msg: "Not Found", }, { // SDK only reads request ID and host ID from the header. The values // in message body are ignored. RespFn: func() *http.Response { body := `SomeExceptionException messageignored-request-idignored-host-id` return &http.Response{ StatusCode: 500, Header: http.Header{ "X-Amz-Request-Id": []string{"taken-request-id"}, "X-Amz-Id-2": []string{"taken-host-id"}, }, Body: ioutil.NopCloser(strings.NewReader(body)), ContentLength: int64(len(body)), } }, ReqID: "taken-request-id", HostID: "taken-host-id", Code: "SomeException", Msg: "Exception message", }, { RespFn: func() *http.Response { return &http.Response{ StatusCode: 404, Header: http.Header{ "X-Amz-Request-Id": []string{"abc123"}, "X-Amz-Id-2": []string{"321cba"}, }, Body: ioutil.NopCloser(bytes.NewReader(nil)), ContentLength: -1, } }, ReqID: "abc123", HostID: "321cba", Code: "NotFound", Msg: "Not Found", WithoutStatusMsg: true, }, { RespFn: func() *http.Response { return &http.Response{ StatusCode: 404, Header: http.Header{ "X-Amz-Request-Id": []string{"abc123"}, "X-Amz-Id-2": []string{"321cba"}, }, Body: ioutil.NopCloser(bytes.NewReader(nil)), ContentLength: -1, } }, ReqID: "abc123", HostID: "321cba", Code: "NotFound", Msg: "Not Found", }, } func TestUnmarshalError(t *testing.T) { for i, c := range testUnmarshalCases { s := s3.New(unit.Session) s.Handlers.Send.Clear() s.Handlers.Send.PushBack(func(r *request.Request) { r.HTTPResponse = c.RespFn() if !c.WithoutStatusMsg { r.HTTPResponse.Status = fmt.Sprintf("%d%s", r.HTTPResponse.StatusCode, http.StatusText(r.HTTPResponse.StatusCode)) } }) _, err := s.PutBucketAcl(&s3.PutBucketAclInput{ Bucket: aws.String("bucket"), ACL: aws.String("public-read"), }) if err == nil { t.Fatalf("%d, expected error, got nil", i) } if e, a := c.Code, err.(awserr.Error).Code(); e != a { t.Errorf("%d, Code: expect %s, got %s", i, e, a) } if e, a := c.Msg, err.(awserr.Error).Message(); e != a { t.Errorf("%d, Message: expect %s, got %s", i, e, a) } if e, a := c.ReqID, err.(awserr.RequestFailure).RequestID(); e != a { t.Errorf("%d, RequestID: expect %s, got %s", i, e, a) } if e, a := c.HostID, err.(s3.RequestFailure).HostID(); e != a { t.Errorf("%d, HostID: expect %s, got %s", i, e, a) } } } const completeMultiResp = ` 163 https://bucket.s3-us-west-2.amazonaws.com/keybucketkey"a7d414b9133d6483d9a1c4e04e856e3b-2" 0 ` func Test200NoErrorUnmarshalError(t *testing.T) { s := s3.New(unit.Session) s.Handlers.Send.Clear() s.Handlers.Send.PushBack(func(r *request.Request) { r.HTTPResponse = &http.Response{ StatusCode: 200, Header: http.Header{ "X-Amz-Request-Id": []string{"abc123"}, "X-Amz-Id-2": []string{"321cba"}, }, Body: ioutil.NopCloser(strings.NewReader(completeMultiResp)), ContentLength: -1, } r.HTTPResponse.Status = http.StatusText(r.HTTPResponse.StatusCode) }) _, err := s.CompleteMultipartUpload(&s3.CompleteMultipartUploadInput{ Bucket: aws.String("bucket"), Key: aws.String("key"), UploadId: aws.String("id"), MultipartUpload: &s3.CompletedMultipartUpload{Parts: []*s3.CompletedPart{ {ETag: aws.String("etag"), PartNumber: aws.Int64(1)}, }}, }) if err != nil { t.Fatalf("expect no error, got %v", err) } } const completeMultiErrResp = `SomeExceptionException message` func Test200WithErrorUnmarshalError(t *testing.T) { s := s3.New(unit.Session) s.Handlers.Send.Clear() s.Handlers.Send.PushBack(func(r *request.Request) { r.HTTPResponse = &http.Response{ StatusCode: 200, Header: http.Header{ "X-Amz-Request-Id": []string{"abc123"}, "X-Amz-Id-2": []string{"321cba"}, }, Body: ioutil.NopCloser(strings.NewReader(completeMultiErrResp)), ContentLength: -1, } r.HTTPResponse.Status = http.StatusText(r.HTTPResponse.StatusCode) }) _, err := s.CompleteMultipartUpload(&s3.CompleteMultipartUploadInput{ Bucket: aws.String("bucket"), Key: aws.String("key"), UploadId: aws.String("id"), MultipartUpload: &s3.CompletedMultipartUpload{Parts: []*s3.CompletedPart{ {ETag: aws.String("etag"), PartNumber: aws.Int64(1)}, }}, }) if err == nil { t.Fatalf("expected error, got nil") } if e, a := "SomeException", err.(awserr.Error).Code(); e != a { t.Errorf("Code: expect %s, got %s", e, a) } if e, a := "Exception message", err.(awserr.Error).Message(); e != a { t.Errorf("Message: expect %s, got %s", e, a) } if e, a := "abc123", err.(s3.RequestFailure).RequestID(); e != a { t.Errorf("RequestID: expect %s, got %s", e, a) } if e, a := "321cba", err.(s3.RequestFailure).HostID(); e != a { t.Errorf("HostID: expect %s, got %s", e, a) } }