xeos
/
num-traits
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge #315 

315: Fix float NaN positive/negative assumptions r=cuviper

These are the minimal assumptions to make about `NaN`. Fixes part of #312 (but not the `next` branch).
This commit is contained in:
bors[bot] 2017-07-10 17:31:04 +00:00
parent 31fa9f626a 426034ba09
commit 36b492a191
1 changed files with 21 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
traits/src/float.rs
View File

@ -323,8 +323,26 @@ pub trait Float
/// ``` /// ```
fn signum(self) -> Self; fn signum(self) -> Self;
/// Returns `true` if `self` is positive, including `+0.0` and /// Returns `true` if `self` is positive, including `+0.0`,
/// `Float::infinity()`. /// `Float::infinity()`, and with newer versions of Rust `f64::NAN`.
///
/// ```
/// use num_traits::Float;
/// use std::f64;
///
/// let neg_nan: f64 = -f64::NAN;
///
/// let f = 7.0;
/// let g = -7.0;
///
/// assert!(f.is_sign_positive());
/// assert!(!g.is_sign_positive());
/// assert!(!neg_nan.is_sign_positive());
/// ```
fn is_sign_positive(self) -> bool;
/// Returns `true` if `self` is negative, including `-0.0`,
/// `Float::neg_infinity()`, and with newer versions of Rust `-f64::NAN`.
/// ///
/// ``` /// ```
/// use num_traits::Float; /// use num_traits::Float;
@ -335,29 +353,9 @@ pub trait Float
/// let f = 7.0; /// let f = 7.0;
/// let g = -7.0; /// let g = -7.0;
/// ///
/// assert!(f.is_sign_positive());
/// assert!(!g.is_sign_positive());
/// // Requires both tests to determine if is `NaN`
/// assert!(!nan.is_sign_positive() && !nan.is_sign_negative());
/// ```
fn is_sign_positive(self) -> bool;
/// Returns `true` if `self` is negative, including `-0.0` and
/// `Float::neg_infinity()`.
///
/// ```
/// use num_traits::Float;
/// use std::f64;
///
/// let nan = f64::NAN;
///
/// let f = 7.0;
/// let g = -7.0;
///
/// assert!(!f.is_sign_negative()); /// assert!(!f.is_sign_negative());
/// assert!(g.is_sign_negative()); /// assert!(g.is_sign_negative());
/// // Requires both tests to determine if is `NaN`. /// assert!(!nan.is_sign_negative());
/// assert!(!nan.is_sign_positive() && !nan.is_sign_negative());
/// ``` /// ```
fn is_sign_negative(self) -> bool; fn is_sign_negative(self) -> bool;