From 1e65e9dc51eb79de252b7b7b87e27cfbb7e49287 Mon Sep 17 00:00:00 2001
From: Kent Overstreet <kent.overstreet@gmail.com>
Date: Wed, 20 Apr 2016 15:48:02 -0800
Subject: [PATCH] bigint: Fix calculation of size for multiply temporaries

When x.len() and y.len() are both equal and odd, we have x1.len() + y1.len() + 1
(the required size to multiply x1 and y1) > y.len() + 1

This fixes #187
---
 bigint/src/lib.rs | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/bigint/src/lib.rs b/bigint/src/lib.rs
index effb3ab..c9ca38e 100644
--- a/bigint/src/lib.rs
+++ b/bigint/src/lib.rs
@@ -991,9 +991,11 @@ fn mac3(acc: &mut [BigDigit], b: &[BigDigit], c: &[BigDigit]) {
         let (x0, x1) = x.split_at(b);
         let (y0, y1) = y.split_at(b);
 
-        /* We reuse the same BigUint for all the intermediate multiplies: */
-
-        let len = y.len() + 1;
+        /*
+         * We reuse the same BigUint for all the intermediate multiplies and have to size p
+         * appropriately here: x1.len() >= x0.len and y1.len() >= y0.len():
+         */
+        let len = x1.len() + y1.len() + 1;
         let mut p = BigUint { data: vec![0; len] };
 
         // p2 = x1 * y1
@@ -3827,6 +3829,15 @@ mod biguint_tests {
         }
     }
 
+    #[test]
+    fn test_mul_overflow() {
+        /* Test for issue #187 - overflow due to mac3 incorrectly sizing temporary */
+        let s = "531137992816767098689588206552468627329593117727031923199444138200403559860852242739162502232636710047537552105951370000796528760829212940754539968588340162273730474622005920097370111";
+        let a: BigUint = s.parse().unwrap();
+        let b = a.clone();
+        let _ = a.checked_mul(&b);
+    }
+
     #[test]
     fn test_checked_div() {
         for elm in MUL_TRIPLES.iter() {