From 856a34ca25c6e568d2e065fd5632806f4b43d70e Mon Sep 17 00:00:00 2001 From: Sergey Pepyakin Date: Fri, 29 Jun 2018 14:24:02 +0300 Subject: [PATCH] Merge. --- src/module.rs | 12 ++++++------ src/validation/func.rs | 16 ++++++++-------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/module.rs b/src/module.rs index a3a9fa0..47deb32 100644 --- a/src/module.rs +++ b/src/module.rs @@ -4,7 +4,7 @@ use std::rc::Rc; use std::cell::RefCell; use std::fmt; use std::collections::HashMap; -use parity_wasm::elements::{External, InitExpr, Internal, Opcode, ResizableLimits, Type}; +use parity_wasm::elements::{External, InitExpr, Internal, Instruction, ResizableLimits, Type}; use {Module, Error, Signature, MemoryInstance, RuntimeValue, TableInstance}; use imports::ImportResolver; use global::{GlobalInstance, GlobalRef}; @@ -708,11 +708,11 @@ fn eval_init_expr(init_expr: &InitExpr, module: &ModuleInstance) -> RuntimeValue "Due to validation `code`.len() should be 2" ); match code[0] { - Opcode::I32Const(v) => v.into(), - Opcode::I64Const(v) => v.into(), - Opcode::F32Const(v) => RuntimeValue::decode_f32(v), - Opcode::F64Const(v) => RuntimeValue::decode_f64(v), - Opcode::GetGlobal(idx) => { + Instruction::I32Const(v) => v.into(), + Instruction::I64Const(v) => v.into(), + Instruction::F32Const(v) => RuntimeValue::decode_f32(v), + Instruction::F64Const(v) => RuntimeValue::decode_f64(v), + Instruction::GetGlobal(idx) => { let global = module.global_by_index(idx).expect( "Due to validation global should exists in module", ); diff --git a/src/validation/func.rs b/src/validation/func.rs index cc0cdde..7107e05 100644 --- a/src/validation/func.rs +++ b/src/validation/func.rs @@ -1,5 +1,5 @@ use std::u32; -use parity_wasm::elements::{Opcode, BlockType, ValueType, TableElementType, Func, FuncBody}; +use parity_wasm::elements::{Instruction, BlockType, ValueType, TableElementType, Func, FuncBody}; use common::{DEFAULT_MEMORY_INDEX, DEFAULT_TABLE_INDEX}; use validation::context::ModuleContext; @@ -196,17 +196,17 @@ impl FunctionReader { Ok(context.into_code()) } - fn read_function_body(context: &mut FunctionValidationContext, body: &[Opcode]) -> Result<(), Error> { + fn read_function_body(context: &mut FunctionValidationContext, body: &[Instruction]) -> Result<(), Error> { let body_len = body.len(); if body_len == 0 { return Err(Error("Non-empty function body expected".into())); } loop { - let opcode = &body[context.position]; + let instruction = &body[context.position]; - let outcome = FunctionReader::read_instruction(context, opcode) - .map_err(|err| Error(format!("At instruction {:?}(@{}): {}", opcode, context.position, err)))?; + let outcome = FunctionReader::read_instruction(context, instruction) + .map_err(|err| Error(format!("At instruction {:?}(@{}): {}", instruction, context.position, err)))?; match outcome { Outcome::NextInstruction => (), @@ -223,9 +223,9 @@ impl FunctionReader { } } - fn read_instruction(context: &mut FunctionValidationContext, opcode: &Opcode) -> Result { - use self::Opcode::*; - match *opcode { + fn read_instruction(context: &mut FunctionValidationContext, instruction: &Instruction) -> Result { + use self::Instruction::*; + match *instruction { // Nop instruction doesn't do anything. It is safe to just skip it. Nop => {},