xeos
/
wasmi
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

less misleading name for nth_from_top_mut_unchecked

This commit is contained in:
Andrew Dirksen 2018-11-22 13:47:32 -08:00
parent 21a8744e94
commit ab67889223
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/common/stack.rs
View File

@ -156,9 +156,14 @@ impl<T> StackWithLimit<T> {
/// Return mutable reference to item `depth` distance away from top
///
/// Does not check whether depth is in range.
pub fn nth_from_top_mut_unchecked(&mut self, depth: usize) -> &mut T {
let offset = self.stack.len() - 1 - depth;
&mut self.stack[offset]
///
/// # Panics
///
/// Panics if depth is out of range.
pub fn nth_from_top_mut(&mut self, depth: usize) -> &mut T {
assert!(depth + 1 <= self.stack.len());
let index = self.stack.len() - 1 - depth;
unsafe { self.stack.get_unchecked_mut(index) }
}
/// Swaps two elements in the stack.
@ -179,7 +184,7 @@ impl<T> StackWithLimit<T> {
/// bstack.push(1);
/// bstack.push(2);
/// assert_eq!(bstack.top(), Some(&2));
/// stack.swap(0, 1);
/// bstack.swap(0, 1);
/// assert_eq!(bstack.top(), Some(&1));
/// ```
#[inline]
@ -202,7 +207,7 @@ impl<T> StackWithLimit<T> {
/// bstack.push(1);
/// bstack.push(2);
/// assert_eq!(bstack.top(), Some(&2));
/// assert_eq!(stack.swap_remove(0), 1);
/// assert_eq!(bstack.swap_remove(0), 1);
/// assert_eq!(bstack.top(), Some(&2));
/// ```
pub fn swap_remove(&mut self, index: usize) -> T {

2
src/runner.rs
View File

@ -1368,7 +1368,7 @@ impl ValueStack {
#[inline]
fn pick_mut(&mut self, depth: usize) -> &mut RuntimeValueInternal {
self.0.nth_from_top_mut_unchecked(depth - 1)
self.0.nth_from_top_mut(depth - 1)
}
#[inline]