Commit Graph

1956 Commits

Author SHA1 Message Date
Sam Dodrill a5e296e4eb modules/m_sasl: sasl: fix regression introduced by sasl <-> auth_user integration.
This fixes the null-dereference reported on full-disclosure [1].  A
corrected analysis of the issue
follows below:

When SASL authentication completes, and auth_user is requested,
client_p->user may be NULL. Thusly accessing fields of client_p->user
may cause a null dereference. In these cases, aborting SASL auth
early is a correct interpretation of the IRCv3.1 specification.  The
code must handle this situation, which this commit corrects.

[1]: http://seclists.org/fulldisclosure/2014/Mar/320
2014-03-23 13:57:49 -07:00
Sam Dodrill 1bd7b59879 clicaps: Disable away-notify for now 2014-03-20 07:42:29 -07:00
Sam Dodrill 3a8780867a modules/m_sasl: Emergency patch for m_sasl. Details on full-disclosure 2014-03-17 11:02:55 -07:00
Sam Dodrill be813f8605 src/channel: fix possible null reference in joining 2014-03-09 15:42:07 -07:00
Sam Dodrill c649e42ae9 extensions/m_roleplay: Transmit source name with message 2014-02-18 09:50:59 -08:00
Sam Dodrill a7a510a504 src/supported: add OWNER to 005 output 2014-02-18 08:50:25 -08:00
Sam Dodrill 174c8b49b1 Merge branch 'services-modules' 2014-02-14 19:32:13 -08:00
Sam Dodrill 0ebe9a5930 Merge branch 'purge-cruft' 2014-02-14 19:32:02 -08:00
Sam Dodrill eceffbca02 src/messages.tab: Make ERR_NOOPERHOST more generic 2014-02-14 19:28:40 -08:00
Sam Dodrill 06bfe138d2 modules/m_oper: Prevent password guessing
Change the message for an invalid OPER password to "No appropriate
operator blocks were found for your host".
2014-02-14 19:28:40 -08:00
Sam Dodrill 20b066f6f4 Add TODO for elemental-ircd 6.6 2014-02-02 08:54:48 -08:00
Sam Dodrill 8f1d057a36 Remove old files from the root and finish rebrand 2014-01-30 19:49:46 -08:00
Sam Dodrill 74289701af src/s_user: Add metadata for cloaked hostnames for use with services 2014-01-30 22:37:46 -05:00
Sam Dodrill 1a536989b2 extra: Add modules for services packages 2014-01-30 19:23:52 -08:00
Sam Dodrill 55147df5de src/s_user: Make UID assignment happen once we know it's a valid user 2014-01-29 21:14:09 -08:00
Sam Dodrill 177241882c Merge branch 'ircv3-metadata'
Allow support for the ircv3 metadata verbs while maintaining backwards
compatibility with the old ShadowIRCD verbs
2014-01-17 08:19:39 -08:00
Sam Dodrill ba15f6d690 Merge branch 'fix-non-qs-ts6' 2014-01-17 05:09:40 -08:00
Sam Dodrill d4ea7f897e Merge branch 'grammatical-errors' 2014-01-17 05:09:33 -08:00
Sam Dodrill a3da200088 Merge branch 'owners-immune' 2014-01-17 05:09:16 -08:00
Sam Dodrill 6faf3c2a45 src/client: Remove TS5 logic in the link protocol 2014-01-17 05:07:41 -08:00
Sam Dodrill 3bf316e2dc help: Fix some required oper privileges.
references atheme@charybdis/1de147abc5b145ea3b7c09128ee8d8fb19726ef4
2014-01-11 17:53:50 -08:00
Sam Dodrill 2e1fbf8292 extensions/chm_sslonly: Fix grammatical error
References atheme@charybdis/46b55df60bfbb1d9fa640a819ba270d708e3d2b0
2014-01-11 17:51:36 -08:00
Sam Dodrill c03f7b30c4 bandb: Don't attempt to write to a NULL helper.
Though without a bandb binary your installation is completely screwed.

References atheme@charybdis/c8729b08fb171d80030155c638a65aff93cb1a45
2014-01-11 17:49:21 -08:00
Sam Dodrill 80b3a83cbf src/channel: Fix ordering in kick permission logic 2014-01-10 18:16:08 -08:00
Sam Dodrill 3cfbe05aff Bump up SSL cert generation strength 2014-01-01 04:03:45 -08:00
Sam Dodrill 2f35248278 modules/m_whois: Allow clients to see their own umodes when whoising themselves 2013-12-27 09:32:49 -08:00
Sam Dodrill 0785419045 Remove autojoin_opers
It was broken by the away-notify patch and fixing it is more work than
the feature is useful.
2013-12-26 15:08:55 -08:00
Sam Dodrill 755b88c783 Revert autojoin_opers patch
It causes interesting desyncs of account names when run for more than 2
weeks

Revert "channel: refactor fe3c1c828e and fix surrounding indentation"

This reverts commit 27b08207de.

Revert "src/channel: Fix for autojoin_opers segfault"

This reverts commit 8e1c8b7543.
2013-12-26 15:05:15 -08:00
Sam Dodrill 8bff90d496 modules/core/m_metadata: Re-add support for the old metadata verbs and document the old metadata system. 2013-11-24 14:22:51 -08:00
Sam Dodrill 5810ebb18f modules/code/m_metadata: Changed to conform to IRCv3 command spec 2013-11-24 14:11:00 -08:00
Sam Dodrill be2a7a772c src/messages: Fix reply for STATS o
It previously replied as STATS O. A purely cosmetic fix.
2013-11-24 12:18:17 -08:00
Sam Dodrill b68f994db0 Merge pull request #41 from ariscop/docfix
help/cmode: Document 10 character minimum on +G
2013-11-23 17:23:00 -08:00
Andrew Cook 08879082d1 help/cmode: Document 10 character minimum on +G 2013-11-24 12:08:51 +11:00
Kyle Johnson 77e149bf8b Merge pull request #35 from lyska/remove-old-flags-from-help
help/opers: Remove the old privs and replace with the new system
2013-11-16 11:37:53 -08:00
Kyle Jonhson 27b08207de channel: refactor fe3c1c828e and fix surrounding indentation 2013-11-15 05:00:40 +00:00
Sam Dodrill 399b710cad help/opers: Remove the old privs and replace with the new system 2013-11-14 22:24:31 -05:00
Kyle Jonhson 502490b13a readme: oxford comma... 2013-11-15 02:59:00 +00:00
Kyle Johnson f9b84f1a58 Merge pull request #33 from lyska/fix-my-name
CREDITS: Update contributor nick, change spacing, update URLs
2013-11-14 18:27:27 -08:00
Sam Dodrill 4939f6ee97 CREDITS: Update my nick, change spacing
Changes my nickname to lyska.

Fixes a minor pet peeve on /INFO and accurately shows #rainbow-factory
as the channel for elemental-ircd.

Add my nickname to list of people to ask on IRC in `README.md`
2013-11-14 21:14:05 -05:00
Kyle Johnson d64bf25497 Merge pull request #31 from lyska/m_post-snomask
modules/m_post: Fix s2s message framing issue
2013-11-12 19:25:02 -08:00
Kyle Johnson 9d97f23c96 Merge pull request #28 from lyska/rejigger-help
help: denote that owner, admin and halfops can be disabled in the config
2013-11-12 18:54:01 -08:00
Kyle Johnson 14ed0de487 Merge pull request #27 from lyska/elemental-protocol-deviations
[Documentation] doc/technical/elemental-deviation: new doc file
2013-11-12 18:53:09 -08:00
Sam Dodrill 31b7c1031a modules/m_post: Fix s2s message framing issue 2013-11-11 21:14:19 -05:00
Sam Dodrill fd552b946a doc/technical/elemental-deviation: Add information about elemental's use of global SNOMASKs 2013-11-11 21:02:45 -05:00
Sam Dodrill 4e6a065e62 help: denote that owner, admin and halfops can be disabled in the config 2013-11-10 00:24:53 -05:00
Sam Dodrill 6da1d031e8 doc/technical/elemental-deviation: new doc file
Document protocol changes between vanilla TS6 and Elemental-ircd TS6.
The changes are very minimal and will not likely affect day to day
performance of the IRC daemon, but are still worth mentioning.
2013-11-09 21:22:12 -05:00
Kyle Johnson fe3c1c828e Merge pull request #26 from Niichan/fix-autojoin-opers
src/channel: Fix for autojoin_opers segfault
2013-11-08 23:37:47 -08:00
Sam Dodrill 8e1c8b7543 src/channel: Fix for autojoin_opers segfault 2013-11-07 11:39:43 -08:00
Kyle Johnson 6f979b5e43 Merge pull request #23 from Niichan/help-spellcheck
Fix many typos, spelling and grammatical errors in the helpfiles
2013-11-05 19:06:56 -08:00
Sam Dodrill a95cbf8021 help/opers/c[primsg|notice]: +v
Remember, remember!
    The fifth of November,
    The Gunpowder treason and plot;
    I know of no reason
    Why the Gunpowder treason
    Should ever be forgot!
    Guy Fawkes and his companions
    Did the scheme contrive,
    To blow the King and Parliament
    All up alive.
    Threescore barrels, laid below,
    To prove old England's overthrow.
    But, by God's providence, him they catch,
    With a dark lantern, lighting a match!
    A stick and a stake
    For King James's sake!
    If you won't give me one,
    I'll take two,
    The better for me,
    And the worse for you.
    A rope, a rope, to hang the Pope,
    A penn'orth of cheese to choke him,
    A pint of beer to wash it down,
    And a jolly good fire to burn him.
    Holloa, boys! holloa, boys! make the bells ring!
    Holloa, boys! holloa boys! God save the King!
    Hip, hip, hooor-r-r-ray!
2013-11-05 19:03:27 -08:00